car has 17,000 miles on it. Fronts tires are cupping and road noise is considerable.

I have a noise coming from the right front of my 2007 350z base coupe. It seems to change with weight distribution. The brake pads are fine but applying the brake does make it start/ stop at times but never with any consistency. I do hear the spring when I am parking. Is the spring or shock making this sound while driving. It sounds more like something that is rotating but I am wondering if the turning parts are just shifing the weight making this BAD sound...?