why does my positive battery cable spark when I try to place it on the terminal?

I first thought the battery was the problem because it was dead. I recharged it twice with it starting. The next time it would not turn over. I changed the starter and I believe my friend crossed the wires causeing it to spark when the cables were attached. either that or I have a ground some where. This problem only started when I replace the starter.

yes