car wont start. turn key, hear click, and not cranking. but every thing lights .

Hello, How did you determine that the battery is good? Has it been tested by a proper tester that can check internal integrity and state of charge, along with the ability to hold a load? I would check the battery thoroughly first. Then from there, check all battery cable connections, and connections at the ground and the starter. A draw test may be necessary to see how much power the starter is pulling -- if it's too much, the starter could have an internal problem.