Will reconnecting the battery with the key in the on position damage anything?

What is your question?

After replacing a couple sensors I forgot my key was in the on position when I reconnected the negative terminal.

How long has your 2006 GMC Envoy had this problem?

Only since after replacing a few parts under the hood and accidentally reconnected the battery with the keys in the on position.