Car won't start, also bad strut spring front driver!!!!!!

What is your question?

I just bought a 1994 Nissan altima 5 speed and am having some problems leaving me clueless. 1.) Ever since I got the car home I have had to jump start it. I got a brand new battery but still not starting. The lights and all come on when turning the key over and heater starts blowing. However there is a red box looking thing on the battery cable that if I hit it or move it around the car starts after 40 mins of messing with it. But even with the old battery the lights came on but nothing more. WHAT CAN BE THE ISSUE FOR THIS????? 2.) My driver side strut spring makes a very loud popping noise when I make any kind of turn. You can also feel it pop too. I seen they had a recall for something like this back in 2010 can u tell me if I'm correct. And if I can still get it fixed if it hasn't been yet. Thanks for helping