Do I have to do a alignment After replacing upper control arms

Most certainly you will need to have a wheel alignment performed, including camber, caster and toe adjustments, after replacing such components. The only "terrible job" I can imagine here is not having gotten that advice from your mechanic in the first place!